Stormbriner Fix

[Slipknight]

Im usuing 2.24c sources and some of you may know stormbringer is broken in those so I was wondering if anyone has the fix for it? if so I be very appreciative if someone can give me it.

Thanks,

Slipknight

[Smashing]

the 2.24c im using isnt broke

try harder

[Slipknight]

the 2.24c im using isnt broke

try harder

Ok lemme explain hows its broken then.

When you do criticals or anything it still has the normal effect, its just when your doing a normal hit from 3 feet away you give no damage at all.

Go test your source again and you will see, also test on humans only.

[Smashing]

works for me

[Slipknight]

works for me

try it on humans n00d

[Dyno]

When I get home from work i'll port the code snippet from my working storm bringer.

[marleythe9]

ya.. when a wile ago i remmeber that.. my stormbringer was like that.. i think it still may be like that.. is it fixed in 2.24b??? or is it just 2.24c?

[Smashing]

my 2.24c i just downloaded 2 days ago works


just look harder mate

[Dyno]

Game.cpp


Line 12811

Code: Select all

  if (cEquipPos == DEF_EQUIPPOS_TWOHAND) {
  	// Stormbringer
  	if (m_pClientList[iClientH]->m_pItemList[sItemIndex]->m_sIDnum == 845) {
    if(m_pClientList[iClientH]->m_iInt < 65){
    	SendNotifyMsg(NULL, iClientH, DEF_NOTIFY_ITEMRELEASED, m_pClientList[iClientH]->m_iSpecialAbilityEquipPos, sItemIndex, NULL, NULL);
    	ReleaseItemHandler(iClientH, sItemIndex , TRUE);
    	return FALSE;
    }
  	}
  }

Line 56212

Code: Select all

/*
void CGame::StormBringer(int iClientH, short dX, short dY)
{
	char cOwnerType;
	short sOwner, sAppr2, sAttackerWeapon;
	int  iDamage, iTemp, iV1, iV2, iV3;

	//Stormbringer

	if (m_pClientList[iClientH]->m_sItemEquipmentStatus[DEF_EQUIPPOS_RHAND] != -1) {
  m_pMapList[m_pClientList[iClientH]->m_cMapIndex]->GetOwner(&sOwner, &cOwnerType, dX, dY);

  iTemp = m_pClientList[iClientH]->m_sItemEquipmentStatus[DEF_EQUIPPOS_RHAND]; 
  sAppr2 = (short)((m_pClientList[iClientH]->m_sAppr2 & 0xF000) >> 12);

  if (memcmp(m_pClientList[iClientH]->m_pItemList[iTemp]->m_cName, "StormBringer", 12) == 0){ 

  	switch (cOwnerType) {
  	case DEF_OWNERTYPE_PLAYER:
    if (m_pClientList[sOwner]->m_iAdminUserLevel < 3) {
    	if (sAppr2 != 0) {
      iV1 = m_pClientList[iClientH]->m_cAttackDiceThrow_L;
      iV2 = m_pClientList[iClientH]->m_cAttackDiceRange_L;
      iV3 = m_pClientList[iClientH]->m_cAttackBonus_L;

      if (m_pClientList[iClientH]->m_cMagicEffectStatus[ DEF_MAGICTYPE_BERSERK ] != 0){
      	iDamage = iDice(iV1*2,iV2*2)+iV3;
      }    	
      else{
      	iDamage = iDice(iV1,iV2)+iV3;
      }

      m_pClientList[sOwner]->m_iHP -= iDamage;
      if (m_pClientList[sOwner]->m_iHP <= 0){
      	sAttackerWeapon = 1;
      	m_pClientList[sOwner]->m_iHP = 0;

      	m_pClientList[sOwner]->m_bIsKilled = TRUE;
      	m_pClientList[sOwner]->m_iLastDamage = iDamage;
      	SendNotifyMsg(NULL, sOwner, DEF_NOTIFY_HP, NULL, NULL, NULL, NULL);
      	SendEventToNearClient_TypeA(sOwner, DEF_OWNERTYPE_PLAYER, MSGID_EVENT_MOTION, DEF_OBJECTDYING, iDamage, sAttackerWeapon, NULL);
      	m_pMapList[m_pClientList[sOwner]->m_cMapIndex]->ClearOwner(14, sOwner, DEF_OWNERTYPE_PLAYER, m_pClientList[sOwner]->m_sX, m_pClientList[sOwner]->m_sY);
      	m_pMapList[m_pClientList[sOwner]->m_cMapIndex]->SetDeadOwner(sOwner, DEF_OWNERTYPE_PLAYER, m_pClientList[sOwner]->m_sX, m_pClientList[sOwner]->m_sY);
      }
      else{
      	SendNotifyMsg(NULL, sOwner, DEF_NOTIFY_HP, NULL, NULL, NULL, NULL);	
      	SendEventToNearClient_TypeA(sOwner, DEF_OWNERTYPE_PLAYER, MSGID_EVENT_MOTION, DEF_OBJECTDAMAGE, iDamage, NULL, NULL);
      }
    	}
    }
    break;

[Dyno]

If it doesnt work Let me know, either here or by PM.

[Dyno]

Oh also
IN Game.h

Line 702

Code: Select all

void StormBringer(int iClientH, short dX, short dY);

Forgot that part.

[Slipknight]

hmm im guessing its because I changed its item ID lol what a stupid mistake on my part .

Thanks anyway Dyno I noticed that when you posted the codes (which are all in my source).

[Dyno]

Yeah make sure it's the right item ID # lol, that would be a start on why it doesnt work.